Globally enable comments on install #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 6.1 you have to explicitly install the add-on in the Add-ons control panel. If you do that, then you obviously want discussions to be enabled globally. I think this also helps for the Volto case, where a Discussion control panel is missing, so in Plone 6.0 you cannot even properly enable comments.
This was only used in the `collection-integration-test.txt`, but this is actually currently not being tested.
|
@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
4 tasks
|
Several plone/meta tests are expected to fail because the current main branch has conflicts with released versions of other packages. That will be fixed once I release another 6.1 alpha. |
|
@jenkins-plone-org please run jobs |
mauritsvanrees
added a commit
to plone/plone.restapi
that referenced
this pull request
Sep 2, 2024
In Plone 6.1, when you actively activate plone.app.discussion, we may globally enable comments by default. This is when plone/plone.app.discussion#244 gets merged. We already had eight or so tests that explicitly globally enable comments. Now we explicitly globally disable them in two others. Then the tests work in Plone 6.0 and 6.1. See two test failures here for the plone.app.discussion PR: https://jenkins.plone.org/job/pull-request-6.1-3.10/311/
|
Two plone.restapi tests fail: This needs a test fix in plone.restapi: |
mauritsvanrees
added a commit
to plone/plone.restapi
that referenced
this pull request
Sep 4, 2024
In Plone 6.1, when you actively activate plone.app.discussion, we may globally enable comments by default. This is when plone/plone.app.discussion#244 gets merged. We already had eight or so tests that explicitly globally enable comments. Now we explicitly globally disable them in two others. Then the tests work in Plone 6.0 and 6.1. See two test failures here for the plone.app.discussion PR: https://jenkins.plone.org/job/pull-request-6.1-3.10/311/
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Sep 4, 2024
Branch: refs/heads/main Date: 2024-09-04T21:43:29+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/plone.restapi@7b1f0f4 Explicitly globally disable comments in the tests that need it. (#1805) In Plone 6.1, when you actively activate plone.app.discussion, we may globally enable comments by default. This is when plone/plone.app.discussion#244 gets merged. We already had eight or so tests that explicitly globally enable comments. Now we explicitly globally disable them in two others. Then the tests work in Plone 6.0 and 6.1. See two test failures here for the plone.app.discussion PR: https://jenkins.plone.org/job/pull-request-6.1-3.10/311/ Files changed: A news/244.tests M src/plone/restapi/tests/test_dxcontent_serializer.py
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Sep 4, 2024
Branch: refs/heads/main Date: 2024-09-04T21:43:29+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/plone.restapi@7b1f0f4 Explicitly globally disable comments in the tests that need it. (#1805) In Plone 6.1, when you actively activate plone.app.discussion, we may globally enable comments by default. This is when plone/plone.app.discussion#244 gets merged. We already had eight or so tests that explicitly globally enable comments. Now we explicitly globally disable them in two others. Then the tests work in Plone 6.0 and 6.1. See two test failures here for the plone.app.discussion PR: https://jenkins.plone.org/job/pull-request-6.1-3.10/311/ Files changed: A news/244.tests M src/plone/restapi/tests/test_dxcontent_serializer.py
|
The Jenkins jobs pass. I merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an afterthought of the just merged PLIP 3958.
In 6.1 you have to explicitly install the add-on in the Add-ons control panel.
If you do that, then you obviously want discussions to be enabled globally.
I think this also helps for the Volto case, where a Discussion control panel is missing, so in Plone 6.0 you cannot even properly enable comments.
Also, this gets rid of some test code that was only needed for ancient ATTopics. This is totally unrelated, I just happened to notice this while editing
testing.py.