Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test "Add a Comment to a Document and bulk delete it" #227

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

wesleybl
Copy link
Member

@wesleybl wesleybl commented Mar 7, 2024

Fix test robot. Wait for the option is enable before select it.

Even after #226, we still had failure. This is a new attempt to make the test more robust.

@mister-roboto
Copy link

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@wesleybl
Copy link
Member Author

wesleybl commented Mar 7, 2024

@jenkins-plone-org please run jobs

Fix test robot. Wait for the option is enable before
select it.
@wesleybl
Copy link
Member Author

wesleybl commented Mar 8, 2024

@jenkins-plone-org please run jobs

@wesleybl
Copy link
Member Author

wesleybl commented Mar 8, 2024

Testing again to make sure the fix works.

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit ea4858c into master Mar 8, 2024
13 checks passed
@davisagli davisagli deleted the fix_robot branch March 8, 2024 07:18
@mauritsvanrees
Copy link
Member

@wesleybl Thanks for you work on this! I appreciate it. Those intermittently failing robot tests are irritating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants