Skip to content

Commit

Permalink
Merge pull request #236 from plivo/VT-3870
Browse files Browse the repository at this point in the history
VT-3870:namingChange
  • Loading branch information
huzaif-plivo authored Feb 2, 2022
2 parents c557dcc + b920a85 commit ee93816
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 11 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## [v4.27.0](https://github.com/plivo/plivo-node/tree/v4.27.0) (2022-02-02)
**Features - MPCStartCallRecording**
- Parameter change from statusCallback to recordingCallback

## [v4.26.1](https://github.com/plivo/plivo-node/tree/v4.26.1) (2022-01-21)
**Bug Fix**
- Making AppId non mandatory for Buy number and update number APIs(https://github.com/plivo/plivo-node/pull/234)
Expand Down
20 changes: 10 additions & 10 deletions lib/resources/multiPartyCall.js
Original file line number Diff line number Diff line change
Expand Up @@ -363,15 +363,15 @@ export class MultiPartyCall extends PlivoResource{
params.fileFormat = 'mp3'
}

if(params.statusCallbackUrl){
validUrl('statusCallbackUrl', params.statusCallbackUrl, false)
if(params.recordingCallbackUrl){
validUrl('recordingCallbackUrl', params.recordingCallbackUrl, false)
}

if(params.statusCallbackMethod){
validParam('statusCallbackMethod', params.statusCallbackMethod.toUpperCase(), [String], false, ['GET', 'POST'])
if(params.recordingCallbackMethod){
validParam('recordingCallbackMethod', params.recordingCallbackMethod.toUpperCase(), [String], false, ['GET', 'POST'])
}
else {
params.statusCallbackMethod = 'POST'
params.recordingCallbackMethod = 'POST'
}
params.isVoiceRequest = 'true';
return super.executeAction(this.id + '/Record/', 'POST', params)
Expand Down Expand Up @@ -445,15 +445,15 @@ export class MultiPartyCallParticipant extends PlivoSecondaryResource{
params.fileFormat = 'mp3'
}

if(params.statusCallbackUrl){
validUrl('statusCallbackUrl', params.statusCallbackUrl, false)
if(params.recordingCallbackUrl){
validUrl('recordingCallbackUrl', params.recordingCallbackUrl, false)
}

if(params.statusCallbackMethod){
validParam('statusCallbackMethod', params.statusCallbackMethod.toUpperCase(), [String], false, ['GET', 'POST'])
if(params.recordingCallbackMethod){
validParam('recordingCallbackMethod', params.recordingCallbackMethod.toUpperCase(), [String], false, ['GET', 'POST'])
}
else {
params.statusCallbackMethod = 'POST'
params.recordingCallbackMethod = 'POST'
}
params.isVoiceRequest = 'true';
return super.executeAction(this.id , this.secondaryId + '/Record', 'POST', params)
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "plivo",
"version": "4.26.1",
"version": "4.27.0",
"description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML",
"homepage": "https://github.com/plivo/plivo-node",
"files": [
Expand Down

0 comments on commit ee93816

Please sign in to comment.