Merge pull request #294 from plivo/PHONUM-2705

handling the new status code for HM
plivo · Mar 14, 2023 · de012aa · de012aa
2 parents 15e7426 + a3077c2
commit de012aa
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,8 @@
 # Change Log
+## [4.43.0](https://github.com/plivo/plivo-node/tree/v4.43.0) (2023-03-14)
+**Adding new status code - Hosted Messaging order**
+- Added new status code for create hosted messaging order.
+
 ## [4.42.0](https://github.com/plivo/plivo-node/tree/v4.42.0) (2023-03-07)
 **Bug fix - 'text' parameter should be optional for MMS**
 - Make `text` as an optional parameter for [sending MMS](https://www.plivo.com/docs/sms/api/message#send-a-message).

diff --git a/lib/resources/hostedMessagingNumber.js b/lib/resources/hostedMessagingNumber.js
@@ -127,7 +127,6 @@ export class HostedMessagingNumber extends PlivoResource {
   create(params = {}) {
     let client = this[clientKey];
     return new Promise((resolve, reject) => {
-      params.multipart = true;
       client('POST', action, params)
         .then(response => {
           let object = new CreateHostedMessagingNumberResponse(response.body, idField);

diff --git a/lib/rest/axios.js b/lib/rest/axios.js
@@ -76,6 +76,7 @@ export function Axios(config) {
             401: Exceptions.AuthenticationError,
             404: Exceptions.ResourceNotFoundError,
             405: Exceptions.InvalidRequestError,
+            406: Exceptions.NotAcceptableError,
             500: Exceptions.ServerError,
           } [response.status] || Error;
 
@@ -103,6 +104,7 @@ export function Axios(config) {
             401: Exceptions.AuthenticationError,
             404: Exceptions.ResourceNotFoundError,
             405: Exceptions.InvalidRequestError,
+            406: Exceptions.NotAcceptableError,
             500: Exceptions.ServerError,
           } [error.response.status] || Error;
           if (!_.inRange(error.response.status, 200, 300)) {
@@ -193,6 +195,7 @@ export function Axios(config) {
               401: Exceptions.AuthenticationError,
               404: Exceptions.ResourceNotFoundError,
               405: Exceptions.InvalidRequestError,
+              406: Exceptions.NotAcceptableError,
               500: Exceptions.ServerError,
             } [response.status] || Error;
 
@@ -219,6 +222,7 @@ export function Axios(config) {
               401: Exceptions.AuthenticationError,
               404: Exceptions.ResourceNotFoundError,
               405: Exceptions.InvalidRequestError,
+              406: Exceptions.NotAcceptableError,
               500: Exceptions.ServerError,
             } [error.response.status] || Error;
             if (!_.inRange(error.response.status, 200, 300)) {
@@ -242,6 +246,7 @@ export function Axios(config) {
             401: Exceptions.AuthenticationError,
             404: Exceptions.ResourceNotFoundError,
             405: Exceptions.InvalidRequestError,
+            406: Exceptions.NotAcceptableError,
             500: Exceptions.ServerError,
           } [response.status] || Error;
 
@@ -275,6 +280,7 @@ export function Axios(config) {
             401: Exceptions.AuthenticationError,
             404: Exceptions.ResourceNotFoundError,
             405: Exceptions.InvalidRequestError,
+            406: Exceptions.NotAcceptableError,
             500: Exceptions.ServerError,
           } [error.response.status] || Error;
           if (!_.inRange(error.response.status, 200, 300)) {

diff --git a/lib/utils/exceptions.js b/lib/utils/exceptions.js
@@ -5,3 +5,4 @@ export class InvalidRequestError extends PlivoRestError { }
 export class PlivoXMLError extends PlivoRestError { }
 export class PlivoXMLValidationError extends PlivoRestError { }
 export class AuthenticationError extends PlivoRestError { }
+export class NotAcceptableError extends PlivoRestError { }
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "plivo",
-  "version": "4.42.0",
+  "version": "4.43.0",
   "description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML",
   "homepage": "https://github.com/plivo/plivo-node",
   "files": [