Fix make start and UT

plivo · Oct 17, 2024 · 4e8ed57 · 4e8ed57
1 parent dfa06d1
commit 4e8ed57
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/Makefile b/Makefile
@@ -5,7 +5,11 @@ build:
 
 start:
 	docker-compose up --build --remove-orphans --detach
-	docker attach $(shell docker-compose ps -q javaSDK)
+	# Wait for the container to be running before attaching
+	@while [ -z "$$(docker-compose ps -q javaSDK)" ]; do \
+		sleep 1; \
+	done
+	docker attach $$(docker-compose ps -q javaSDK)
 
 test:
 	@[ "${CONTAINER}" ] && \

diff --git a/src/test/java/com/plivo/api/VerifySessionTest.java b/src/test/java/com/plivo/api/VerifySessionTest.java
@@ -28,15 +28,15 @@ public void setUp() throws Exception {
   public void invalidSessionCreated() throws Exception {
     expectResponse("createSession.json", 202);
 
-    VerifySession.creator(null,null, null, null, null,null, null, null, 0, null)
+    VerifySession.creator(null,null, null, null, null,null, null, null, 0, null, null)
       .create();
   }
 
   @Test
   public void sessionCreated() throws Exception {
     expectResponse("createSession.json", 202);
 
-    VerifySession.creator(null,"+1234567890", null, null, null, null, null, null, 0, null)
+    VerifySession.creator(null,"+1234567890", null, null, null, null, null, null, 0, null, null)
       .create();
   }