Migrate python debugging logic to rules #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagovtristao
commented
Jan 13, 2022
tools/wheel_resolver/test/BUILD
Outdated
Comment on lines
3
to
14
| package( | ||
| python = { | ||
| "WHEEL_REPO": "https://get.please.build/third_party/python/py3", | ||
| "WHEEL_NAME_SCHEME": [ | ||
| "{url_base}/{package_name}-{version}-${{OS}}_${{ARCH}}.whl", | ||
| "{url_base}/{package_name}-{version}.whl", | ||
| "https://files.pythonhosted.org/packages/py3/{initial}/{package_name}/{package_name}-{version}-py3-none-any.whl", | ||
| "https://files.pythonhosted.org/packages/py2.py3/{initial}/{package_name}/{package_name}-{version}-py2.py3-none-any.whl", | ||
| ], | ||
| }, | ||
| ) | ||
|
|
There was a problem hiding this comment.
I copied this over from third_party/python/BUILD as there's a python_wheel rule below that needs it. Not sure if this change is the correct one.
There was a problem hiding this comment.
@samwestmoreland can you confirm?
There was a problem hiding this comment.
Yeah as we were saying on Friday it shouldn't need it because the python_wheel() should fall back onto the wheel resolver tool. The issue was to do with the wheel resolver tool not being able to find old protobuf versions (re-opened #19).
Tatskaari
approved these changes
Jan 26, 2022
Yeah, things probably need to be re-tested once that code is ported over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.