Skip to content

Commit

Permalink
Update Go to 1.23.2 to make puku aware of package iter (#135)
Browse files Browse the repository at this point in the history
Also, remove checked-in generated file and update .plzconfig to make it generate imports
  • Loading branch information
toastwaffle authored Nov 4, 2024
1 parent 2807326 commit ea0c04d
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 275 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ jobs:
- uses: actions/setup-go@v2
with:
go-version: "^1.23"
- name: Build go_root_packages
# This makes sure the knownimports/go_root_packages file exists as a real file for golangci-lint
run: ./pleasew build //knownimports:go_root_packages && mv $(readlink knownimports/go_root_packages) knownimports/go_root_packages
- name: golangci-lint
uses: golangci/golangci-lint-action@v2
with:
Expand Down
7 changes: 6 additions & 1 deletion .plzconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
[parse]
preloadsubincludes = ///go//build_defs:go

[build]
LinkGeneratedSources = true
DownloadLinkable = true
UpdateGitignore = true

[Plugin "go"]
Target = //plugins:go
ImportPath = github.com/please-build/puku
Expand All @@ -19,4 +24,4 @@ Desc = Runs golangci-lint as done by our CI
cmd = run //third_party/binary:golangci-lint -- run

[BuildConfig]
go-version = 1.22.3
go-version = 1.23.2
4 changes: 4 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
Version 1.13.0
--------------
* Build with Go 1.23.2 to pull in new packages

Version 1.12.1
--------------
* Rename `VERSION` to `PUKU_VERSION` to allow running
Expand Down
2 changes: 1 addition & 1 deletion PUKU_VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.12.1
1.13.0
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/please-build/puku

go 1.19
go 1.23

require (
github.com/fsnotify/fsnotify v1.7.0
Expand Down
3 changes: 3 additions & 0 deletions knownimports/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@

# Entries below this point are managed by Please (DO NOT EDIT)
go_root_packages
1 change: 1 addition & 0 deletions knownimports/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ genrule(
srcs = ["//third_party/go:toolchain"],
outs = ["go_root_packages"],
cmd = f'find {root} -name "*.a" | sed -e s=^{root}/== | sed -e s="\.a\$"== > $OUT',
labels = ["codegen"],
)

go_library(
Expand Down
272 changes: 0 additions & 272 deletions knownimports/go_root_packages

This file was deleted.

0 comments on commit ea0c04d

Please sign in to comment.