Skip to content

Commit

Permalink
resolve deps for go_repo to subrepo targets rather than its install
Browse files Browse the repository at this point in the history
  • Loading branch information
goddenrich committed May 4, 2024
1 parent 6b85e4b commit 309be17
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions generate/generate.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,8 @@ func (u *updater) readModules(file *build.File) error {
module := repoRule.AttrString("module")
u.modules = append(u.modules, module)

installs := repoRule.AttrStrings("install")
if len(installs) > 0 {
addInstalls(repoRule.Name(), module, installs)
}
// we do not add installs for go_repos. We prefer to resolve deps
// to the subrepo targets since this is more efficient for please.
}

goMods := file.Rules("go_module")
Expand Down

0 comments on commit 309be17

Please sign in to comment.