Skip to content

Commit

Permalink
Fix readme and move config to a test profile (#3)
Browse files Browse the repository at this point in the history
  • Loading branch information
Tatskaari authored Dec 8, 2021
1 parent 7b3b114 commit d9dec18
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 10 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/plugin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ jobs:
- name: Checkout code
uses: actions/checkout@v2
- name: Run tests
run: ./pleasew test --log_file plz-out/log/test.log -e e2e
- name: Run e2e test
run: ./pleasew test --log_file plz-out/log/e2e.log -i e2e
run: ./pleasew test --profile test --log_file plz-out/log/test.log
- name: Archive logs
if: always()
uses: actions/upload-artifact@v2
Expand Down
5 changes: 2 additions & 3 deletions .plzconfig
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
; TODO(jpoole): this plugin shouldn't contain the actually proto languages

[Plugin "proto"]
Definition = //build_defs/languages:js


[Plugin "python"]
ModuleDir = third_party.python
Expand All @@ -16,7 +15,7 @@ ExcludePythonRules = true
name = proto

[PluginConfig "definitions"]
ConfigKey = Definition
ConfigKey = LanguageDef
Repeatable = true

[PluginConfig "protoc_tool"]
Expand Down
2 changes: 2 additions & 0 deletions .plzconfig.test
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[Plugin "proto"]
LanguageDef = //build_defs/languages:js
6 changes: 2 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
# Proto rules
Protobuff rules for the [Please](https://please.build) build system.
Protobuf rules for the [Please](https://please.build) build system.

# Basic usage
First add the base proto plugin to your project:
```python
# BUILD
# This adds the plugin to your project
github_repo(
plugin_repo(
name = "proto",
repo = "please-build/proto-rules",
revision = "<Some git tag, commit, or other reference>",
)
```
Expand Down

0 comments on commit d9dec18

Please sign in to comment.