please_go: remove Go <= 1.19 coverage generation code #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterebden
approved these changes
Aug 27, 2024
Go 1.20 made breaking changes to the way in which coverage is computed. This required the `coverageredesign` GOEXPERIMENT to be enabled when using go-rules with Go 1.20 onwards. Go 1.19 has now been EOL for almost a year, and the `coveragedesign` GOEXPERIMENT will be removed from Go shortly, having been the default for around 18 months. Remove the following features from please_go that supported the Go <= 1.19 method of computing coverage: * The `covervars` command, which is no longer necessary with `coverageredesign`. * The generation of Go <= 1.19-compatible test main files with the `testmain` command.
chrisnovakovic
force-pushed
the
please_go-remove-old-coverage
branch
from
b5ea0b4 to
5097667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.20 made breaking changes to the way in which coverage is computed. This required the
coverageredesignGOEXPERIMENT to be enabled when using go-rules with Go 1.20 onwards.Go 1.19 has now been EOL for almost a year, and the
coveragedesignGOEXPERIMENT will be removed from Go shortly, having been the default for around 18 months. Remove the following features from please_go that supported the Go <= 1.19 method of computing coverage:covervarscommand, which is no longer necessary withcoverageredesign.testmaincommand.