Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set build tags with config option #199

Merged
merged 14 commits into from
Jan 11, 2024
Merged

Set build tags with config option #199

merged 14 commits into from
Jan 11, 2024

Conversation

samwestmoreland
Copy link
Contributor

@samwestmoreland samwestmoreland commented Jan 11, 2024 •
edited
Loading

With this change, you can now set go build tags in the config and they'll be set on the go_library targets that comprise go repos.

This has been tested on github.com/containerd/containerd which we use internally and require to be built with a no_btrfs tag.

goddenrich
goddenrich approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@goddenrich goddenrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me

Tatskaari
Tatskaari approved these changes Jan 11, 2024
View reviewed changes
build_defs/go.build_defs Outdated Show resolved Hide resolved
@samwestmoreland samwestmoreland merged commit 5149d99 into please-build:master Jan 11, 2024
3 checks passed
@samwestmoreland samwestmoreland deleted the build-tags branch January 11, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goddenrich goddenrich goddenrich approved these changes

@Tatskaari Tatskaari Tatskaari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samwestmoreland @Tatskaari @goddenrich