Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct dependency on modinfo to go_module #162

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Add direct dependency on modinfo to go_module #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f47b2a6
Add dep
peterebden Oct 2, 2023
8b6dc65
update changelog
peterebden Oct 2, 2023
a3edf9f
toolchain update, looks like 1.20.3 might have been deleted
peterebden Oct 2, 2023
24947fc
okay go back down to 1.20.8 then
peterebden Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
Version 1.9.1
-------------
* Support :all syntax correctly when embedding (#161)
* Minor dependency fix to 1.9.0

Version 1.9.0
-------------
* Fix: don't check toolchain version when a version isn't provided (#154)
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.9.0
1.9.1
2 changes: 1 addition & 1 deletion build_defs/go.build_defs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,7 +1443,7 @@ def go_module(name:str='', module:str, version:str='', download:str='', deps:lis
return filegroup(
name = name,
srcs = [a_rule],
deps = deps + [pkg_info] if CONFIG.GO.PKG_INFO else deps,
deps = deps + [pkg_info, modinfo] if CONFIG.GO.PKG_INFO else deps,
exported_deps = exported_deps,
provides = provides,
labels = labels + [f"go_package:{i}" for i in install] + ["go_module_path:" + module],
Expand Down
2 changes: 1 addition & 1 deletion third_party/go/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ subinclude("//build_defs:go")

go_toolchain(
name = "toolchain",
version = "1.20.3",
version = "1.20.8",
install_std = False,
)

Expand Down
Loading