Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make modinfo generation more efficient #157

Merged
merged 7 commits into from
Sep 30, 2023

Conversation

peterebden
Copy link
Contributor

It's pulling down a whole transitive dependency tree but only needs the .modinfo files. This makes it significantly more efficient by matching up require/provide so it only fetches the files it needs.

@peterebden peterebden force-pushed the modinfo-more-efficient branch from b823755 to 68653be Compare September 30, 2023 11:14
@peterebden peterebden force-pushed the modinfo-more-efficient branch from 68653be to 444e233 Compare September 30, 2023 11:17
@peterebden
Copy link
Contributor Author

Right I've tested this against please_go in this repo and some more complex internal binaries and am getting identical outputs to before (after fixing a couple of things). Think this should be good to go (especially since both my reviewers are on holiday...).

@peterebden peterebden merged commit 8ce1a90 into please-build:master Sep 30, 2023
4 checks passed
@peterebden peterebden deleted the modinfo-more-efficient branch September 30, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant