Merge branch 'master' into wasmtime

.github/workflows/plugin.yaml

@@ -8,15 +8,41 @@ jobs:
         uses: actions/checkout@v2
       - name: Run tests
         run: ./pleasew test -p -v notice --log_file plz-out/log/test.log
-      - name: Run tests with coverage
-        run: ./pleasew cover -p -v notice --nocoverage_report --log_file plz-out/log/test.log
       - name: Archive logs
         if: always()
         uses: actions/upload-artifact@v2
         with:
           name: logs
           path: |
             plz-out/log
+  test_coverage:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+      - name: Run tests with coverage
+        run: ./pleasew cover -p -v notice --nocoverage_report --log_file plz-out/log/test_coverage.log
+      - name: Archive logs
+        if: always()
+        uses: actions/upload-artifact@v2
+        with:
+          name: coverage_logs
+          path: |
+            plz-out/log
+  test_debug:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+      - name: Build with debug configuration
+        run: ./pleasew build -c dbg -p -v notice --log_file plz-out/log/test_debug.log
+      - name: Archive logs
+        if: always()
+        uses: actions/upload-artifact@v2
+        with:
+          name: debug_logs
+          path: |
+            plz-out/log
   release:
     needs: [test]
     runs-on: ubuntu-latest

.plzconfig

@@ -1,5 +1,5 @@
 [Please]
-Version = >=17.0.0-beta.8
+Version = >=17.2.0
 
 [build]
 hashcheckers = sha256
@@ -82,7 +82,7 @@ Help = Changes the test working directory to be the package to be more inline wi
 [PluginConfig "cpp_coverage"]
 Type = bool
 DefaultValue = false
-Help = Whether to build C components with coverage 
+Help = Whether to build C components with coverage
 
 [PluginConfig "c_flags"]
 Inherit = true
@@ -136,5 +136,10 @@ Help = Compile for the Go race detector
 Optional = true
 Help = A built target for a go.mod, which can help avoid the need to pass modules via requirements to go_repo.
 
+[PluginConfig "pkg_info"]
+Type = bool
+DefaultValue = true
+Help = Generate pkg info for Go targets
+
 [Plugin "shell"]
 Target = //plugins:shell

ChangeLog

@@ -1,3 +1,58 @@
+Version 1.9.2
+-------------
+    * Fix issue with setting _module on go_binary rules within go_repo
+
+
+Version 1.9.1
+-------------
+    * Support :all syntax correctly when embedding (#161)
+    * Minor dependency fix to 1.9.0
+
+Version 1.9.0
+-------------
+    * Fix: don't check toolchain version when a version isn't provided (#154)
+    * `go_repo` now provides module info so `go version -m` works as expected (#158)
+    * Go module info build actions are now more efficient with their inputs (#157)
+
+Version 1.8.2
+-------------
+    * Remove implicit dependency on GCC toolchain when running under coverage profile (#155)
+
+Version 1.8.1
+-------------
+    * Add a config option to allow toggling pkg info generation (#150)
+
+Version 1.8.0
+-------------
+    * Added `pgo_file` argument to `go_library` which enables profile-guided optimisation.
+
+Version 1.7.6
+-------------
+    * Honour `flags` argument correctly to `go_test`
+
+Version 1.7.5
+-------------
+    * Fix issue with missing test results when tests call `os.Exit()` when using go 1.20+. This only
+      caused the report to miss rows, as the test result file wasn't being flushed, but would never
+      cause the test to pass when it should have failed. (#142)
+
+Version 1.7.4
+-------------
+    * Fix issues with with tests using TestMain in go1.20+ where we would run the tests
+      for them. This is the responsibility of TestMain.
+    * Set GOROOT when compiling stdlib as we need this for setting `pkg/include` for cgo/asm (#138)
+
+Version 1.7.3
+-------------
+    * Refactor `please_go` download test to avoid subrepo references (#136)
+      This fixes fatal errors with `plz query graph` in repos that use go-rules, a regression
+      present since version 1.7.0.
+
+Version 1.7.2
+------------
+    * Use correct version of the go tool (#128)
+    * Write `asm.h` to the tmp dir rather than the goroot (#125)
+
 Version 1.7.1
 ------------
     * Added missing `resources` option to `go_benchmark` (#121)

README.md

@@ -76,3 +76,5 @@ go_binary(
 
 Go is especially well suited to writing command line tools and utilities. Binaries can be ran with `plz run`, or used 
 as a tool for other [custom rules](https://please.build/codelabs/genrule/#0). 
+
+**WARNING: From Go 1.20, Golang no longer ships the precompiled standard library and thus you MUST use `go_toolchain` or `go_system_toolchain`.**

VERSION

@@ -1 +1 @@
-1.7.1
+1.9.2

build_defs/cgo.build_defs

@@ -38,7 +38,7 @@ def cgo_library(name:str, srcs:list=[], resources:list=None, go_srcs:list=[], c_
     assert srcs or go_srcs, 'At least one of srcs and go_srcs must be provided'
 
     if CONFIG.BUILD_CONFIG == "cover":
-        linker_flags += ["-lgcov"]
+        linker_flags += ["--coverage"]
 
     if not srcs:
         return go_library(