Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use preloadsubincludes instead of preloadbuilddefs #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use preloadsubincludes instead of preloadbuilddefs #20

wants to merge 1 commit into from

Conversation

samwestmoreland
Copy link
Contributor

@samwestmoreland samwestmoreland commented Sep 27, 2022 •
edited
Loading

I wasn't able to build the plugin on my machine:

test/modules/BUILD:2:15: error: Config has no such property CC
build_defs/cc.build_defs:384:8: error: Config has no such property CC
etc.

but I was able to with preloadsubincludes. Not 100% sure why that is, but IIRC we were moving away from using preloadbuilddefs.

@samwestmoreland samwestmoreland changed the title Use preloadsubincludes rather than preloadbuilddefs Use preloadsubincludes instead of preloadbuilddefs Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samwestmoreland