Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handler.go #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handler.go #24

wants to merge 1 commit into from

Conversation

unreadable
Copy link

@unreadable unreadable commented Feb 23, 2017

GraphQL http handler for this implementation of graphql. It's a production ready custom verison of the graphql/handler that integrates extremly well with this library.

GraphQL http handler for playlyfe/graphql

//Config for handler of the schema
type Config Handler

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zap (and grpc go) have nice patterns for extensible parameterisation. Should use that pattern here so we can evolve the functionality of the handler.

@hsyed
Copy link
Contributor

hsyed commented May 7, 2017

I have integrated your work from #29 to my own project it works well. It would be good to get these components into this repo.

I suggest moving this component to a contrib or ext folder so that the main package remains clean and add a http package there.

@krypton97 The graphiql handler from #29 could also go in with this http package. I would make the graphiql handler configurable so that the graphiql and react versions can be templated in at runtime.

@unreadable
Copy link
Author

@hsyed Glad you find it usefull ;). I have to see how it fits with modern relay and if I should make some changes. I will remake the graphiql handler as there's some stuffs that I might change. Overwall I'll try to make a full toolkit for integrating graphql with react and relay in golang.

@fungl164
Copy link

fungl164 commented Jan 19, 2019

FYI, minor updates https://github.com/luisjakon/playlyfe-handler

  • update context package to "context" (line 4)
  • merge app context (e.g. h.Context) with request context (lines 123-4) (lines 141-2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants