Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post row analytics link #191

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

EdwardBock
Copy link

In relation to #148 . This feature is highly requested by our customers. Would be great to have it.

Thanks for you great work!

@Dan0sz
Copy link
Collaborator

Dan0sz commented Mar 20, 2024

Thanks for your PR! I like this. @metmarkosaric Shall we include this in the next release? Small piece of code, but rather effective feature!

@metmarkosaric
Copy link
Collaborator

we can consider it for sure for one of the upcoming releases!

so this one adds some stats to the post itself but not to the post list? would be nice to see a screenshot or test how this implementation works as I see some people also ask for the stats to be in the post list itself too.

and more importantly is this on by default and is there a way to disable/enable it in the settings?

@EdwardBock
Copy link
Author

Hi there, thank for you quick reaction. It's exactly the opposite @metmarkosaric . This one adds a link to the post list not to the post editor. It is on by default and there is currently no option to disable it. But the links is pretty discreet as it only appears on hover over the posts row.

@metmarkosaric
Copy link
Collaborator

sounds good @EdwardBock, thanks for the contribution! we'll test it and decide how to proceed.

@EdwardBock
Copy link
Author

Any news here?

@Dan0sz Dan0sz changed the base branch from develop to post_row_link May 17, 2024 08:39
@Dan0sz Dan0sz merged commit 60d5046 into plausible:post_row_link May 17, 2024
4 checks passed
@Dan0sz
Copy link
Collaborator

Dan0sz commented May 17, 2024

Hi @EdwardBock,

Thanks for your suggestion!

2 remarks, before we can publish this:

  1. It would be nice to also have the link appear in the pages list, not just posts. (and all custom post types, maybe?)
  2. The link shouldn't appear if "Disable menu in toolbar" is enabled or, when Plausible Self-hosted (Community Edition) is used, when the private shared link is not entered.

Once you've added these changes, we can take it up in a next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants