Use constructor injection for services #1511
Draft
+2,881
−1,692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pjcdawkins
commented
Nov 27, 2024
•
pjcdawkins
commented
- fix base class constructors by moving them to separate services
pjcdawkins
force-pushed
the
rector-rule-constructor-injection
branch
4 times, most recently
from
0c670e1
to
8b923a2
Compare
4 tasks
pjcdawkins
force-pushed
the
symfony-compiled-service-container
branch
from
d920fcd
to
1bfcfe5
Compare
pjcdawkins
force-pushed
the
rector-rule-constructor-injection
branch
2 times, most recently
from
3a1b932
to
ab85059
Compare
pjcdawkins
changed the title
pjcdawkins
force-pushed
the
symfony-compiled-service-container
branch
from
1bfcfe5
to
997a5f1
Compare
pjcdawkins
force-pushed
the
rector-rule-constructor-injection
branch
from
cb37145
to
2e02237
Compare
pjcdawkins
force-pushed
the
rector-rule-constructor-injection
branch
from
2e02237
to
e0fb15b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.