Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test for Namespace Already Exists #60

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

mfl-code
Copy link
Contributor

This is resubmission of #57 - since the commits were not verified correctly.

Description

Adding test for Namespace Already Exists

TODOs

Read the Contribution guidelines.

  • Generate the docs.
  • Run the relevant tests successfully.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Adding test

Migration Guide

N/A

@mfl-code mfl-code closed this Jul 25, 2024
@mfl-code mfl-code reopened this Jul 25, 2024
@ganievs
Copy link
Collaborator

ganievs commented Jul 26, 2024

Hi @mfl-code seems your commits isn't signed yet. Coul'd you follow the instructions and sign them off - https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@mfl-code
Copy link
Contributor Author

@ganievs I got a verified commit, but it looks like you need to re-approve it (I have "1 workflow awaiting approval" message)

@ganievs ganievs merged commit 11b667f into platacard:main Jul 29, 2024
10 checks passed
@mfl-code mfl-code deleted the exists2 branch August 20, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants