Search attribute resource #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parinmaru2
reviewed
Jul 11, 2024
amibaid
force-pushed
the
search_attribute_resource
branch
from
c3461ce to
6c38cea
Compare
parinmaru2
approved these changes
Jul 18, 2024
|
@ganievs please review/approve this PR when you get a chance. Thanks |
dipali-bhatt
approved these changes
Jul 18, 2024
ganievs
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for a temporal search-attribute resource and data source and unit tests
Addresses issue #34
Added files:
internal/provider/search_attribute_resource.gointernal/provider/search_attribute_data_source.gointernal/provider/search_attribute_resource_test.gointernal/provider/search_attribute_data_source_test.goModified files:
internal/provider/provider.goTODOs
Read the Contribution guidelines.
Release Notes (draft)
Added support for a search attribute resource and data source
Migration Guide