#164 added automatic URL decoding (#166)

* #164 added URL decoding to path and query params * #164 updated changelog + version bump * #164 Removed superfluous isSome-operation * Update src/prologue/core/context.nim Co-authored-by: Philipp Doerner <[email protected]> Co-authored-by: flywind <[email protected]>
planety · May 28, 2022 · e456548 · e456548
1 parent dfcaeef
commit e456548
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,3 +1,7 @@
+## 0.6.0
+
+Added automatic URL decoding when fetching query parameters or path parameters from request object
+
 ## 0.5.8
 
 remove cursor annotation; Prologue should work with ORC (thanks to @Yardanico's advice)

diff --git a/prologue.nimble b/prologue.nimble
@@ -1,6 +1,6 @@
 # Package
 
-version       = "0.5.8"
+version       = "0.6.0"
 author        = "flywind"
 description   = "Prologue is an elegant and high performance web framework"
 license       = "Apache-2.0"

diff --git a/src/prologue/core/constants.nim b/src/prologue/core/constants.nim
@@ -1,4 +1,4 @@
 const
-  PrologueVersion* = "0.5.8"            ## The current version of Prologue.
+  PrologueVersion* = "0.6.0"            ## The current version of Prologue.
   ProloguePrefix* = "PROLOGUE"          ## The helper prefix for environment variables.
   useAsyncHTTPServer* = defined(windows) or defined(usestd) ## Uses `asynchttpserver`.
diff --git a/src/prologue/core/context.nim b/src/prologue/core/context.nim
@@ -353,7 +353,7 @@ func getQueryParamsOption*(ctx: Context, key: string): Option[string] {.inline.}
   ## Gets a param from the query strings. Returns none(string) if the param does not exist.
   ## (for example, "www.google.com/hello?name=12", `name=12`).
   let hasQueryParam = ctx.request.queryParams.hasKey(key)
-  result = if hasQueryParam: some(ctx.request.queryParams[key]) else: none(string)
+  result = if hasQueryParam: some(decodeUrl(ctx.request.queryParams[key])) else: none(string)
 
 func getQueryParams*(ctx: Context, key: string, default = ""): string {.inline.} =
   ## Gets a param from the query strings(for example, "www.google.com/hello?name=12", `name=12`).
@@ -365,7 +365,7 @@ func getPathParamsOption*(ctx: Context, key: string): Option[string] {.inline.}
   ## Gets a route parameter(for example, "/hello/{name}"). Returns none(string)
   ## if the param does not exist.
   let hasPathParam = ctx.request.pathParams.hasKey(key)
-  result = if hasPathParam: some(ctx.request.pathParams[key]) else: none(string)
+  result = if hasPathParam: some(decodeUrl(ctx.request.pathParams[key])) else: none(string)
 
 func getPathParams*(ctx: Context, key: string): string {.inline.} =
   ## Gets the route parameters(for example, "/hello/{name}"). Returns an empty