Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mohe/stats of prof on course #164

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MoheEdeen
Copy link
Contributor

is this good? #119

@kandasamyc
Copy link
Contributor

kandasamyc commented May 27, 2024

Can you add a picture here of what this change makes it look like?

@MoheEdeen
Copy link
Contributor Author

Can you add a picture here of what this change makes it look like?

here:
image

<script type="text/javascript" src="{% static 'js/chart.min.js' %}"></script>
<script src="https://code.jquery.com/jquery-3.6.0.min.js"></script>
Copy link

@gamesover gamesover Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see base_main.html already contains
<script type="text/javascript" src="{% static 'js/jquery-3.5.1.min.js' %}"></script>

Not sure whether we want to introduce https://code.jquery.com/jquery-3.6.0.min.js here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants