Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timestamps back to compact message cards #1267

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Conversation

mplorentz
Copy link
Member

Not sure when these went away, but I don't think it was intentional. I also fixed an Xcode 14.2 bug.

@mplorentz mplorentz requested a review from martindsq June 1, 2023 01:04
@boreq
Copy link
Contributor

boreq commented Jun 6, 2023

I think we may have removed them on purpose because of some reasoning around not getting updates quickly enough and that users shouldn't ignore old content just because it is old and therefore less valid supposedly. I may be misremembering. That being said I support re-enabling them whether it happened on purpose or by accident.

@boreq boreq marked this pull request as draft June 28, 2023 14:59
@boreq
Copy link
Contributor

boreq commented Jun 28, 2023

Matt informed me that this isn't ready as it breaks some things so I am converting it to draft to avoid confusion.

@mplorentz mplorentz marked this pull request as ready for review September 23, 2023 15:09
@mplorentz
Copy link
Member Author

I thought this broke the thread view because the reply box isn't displayed by default. But I realize that it just works differently now: you have to tap the reply button to show the reply view. So this didn't actually break anything and it's ready for review.

@mplorentz mplorentz merged commit 25ba4e2 into main Apr 5, 2024
@mplorentz mplorentz deleted the add-back-timestamps branch April 5, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants