Import old Planetary resources into Terraform #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergelypolonkai
force-pushed
the
terraform
branch
4 times, most recently
from
bbd2e10 to
59469e2
Compare
mplorentz
previously approved these changes
Sep 20, 2024
There was a problem hiding this comment.
I saw the comment that you don't have owner permissions on Cloudflare. I can get you that if needed. Is this code here as an example or would it actually create these records if I ran the terraform playbook?
There was a problem hiding this comment.
It would only create whatever doesnʼt exist.
Iʼm not sure about the owner access; although Terraform could manage the CF account altogether, iʼm not sure we want to go that deep in IaC. If it causes any trouble in the future, iʼll let you know.
gergelypolonkai
force-pushed
the
terraform
branch
2 times, most recently
from
adf5d01 to
456579c
Compare
gergelypolonkai
force-pushed
the
terraform
branch
from
dea55b5 to
54fc2e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.