Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A "Functional" Solution #6

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

A "Functional" Solution #6

wants to merge 20 commits into from

Commits on Oct 28, 2021

  1. Extract method to adjust quality.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    ef03b11 View commit details
    Browse the repository at this point in the history

  2. Extract method to decrement sell-in.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    301dc4c View commit details
    Browse the repository at this point in the history

  3. Move quality floor guard into adjust_quantity method.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    c4ca9b5 View commit details
    Browse the repository at this point in the history

  4. Move quality ceiling guard into adjust_quantity method.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    9da68d2 View commit details
    Browse the repository at this point in the history

  5. Clean up implementation of adjust_quality method.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    40c9071 View commit details
    Browse the repository at this point in the history

  6. Replace sell-in decrement conditional with case statement.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    c27d619 View commit details
    Browse the repository at this point in the history

  7. Move first conditional for quality adjustment into case statement.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    63f5bac View commit details
    Browse the repository at this point in the history

  8. Move second conditional for quality adjustment into case statement.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    30b95b6 View commit details
    Browse the repository at this point in the history

  9. Extract case statement into update method.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    f71f689 View commit details
    Browse the repository at this point in the history

  10. Inlined checks for backstage passes time until sell-in passes.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    728bea8 View commit details
    Browse the repository at this point in the history

  11. Refactor quality guard cases in adjust_quality method.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    8c223dd View commit details
    Browse the repository at this point in the history

  12. Refactor internals of update method to group all quality adjustments … 

    …together.
    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    592a88e View commit details
    Browse the repository at this point in the history

  13. Treat legendary item in update with guard clause and reduce duplicati… 

    …on of calls to decrement_sell_in.
    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    5a5ea5e View commit details
    Browse the repository at this point in the history

  14. Extract quality update logic into Procs.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    7c2b127 View commit details
    Browse the repository at this point in the history

  15. Reduce duplication of call methods into updater procs.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    957f81e View commit details
    Browse the repository at this point in the history

  16. Replace guard clause with updater Proc for legendary item.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    83d663f View commit details
    Browse the repository at this point in the history

  17. Moved decrement sell-in behavior into updater Procs.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    e61ab80 View commit details
    Browse the repository at this point in the history

  18. Introduce ITEM_TYPE_MAP to ease lookup of Proc from UPDATERS.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    f2f67b6 View commit details
    Browse the repository at this point in the history

  19. Introduce Conjured Mana Cake into Gilded Rose inventory.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    e1fe166 View commit details
    Browse the repository at this point in the history

  20. Extract item type lookup into own method.

    @plainprogrammer
    plainprogrammer committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    690e56a View commit details
    Browse the repository at this point in the history