Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#10571 limit email template access by user groups #446

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pkp/pkp-lib#10571 limit email template access by user groups #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/components/Container/ManageEmailsPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,14 @@ export default {
});
}

// Remove user group fields if current mailable does not support specifying user group access
if (!this.currentMailable.canAssignUserGroupToTemplates) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think more of this can be done on the PHP side of things in the EmailTemplateForm. This kind of goes for all of the UI side of things, especially at this stage. We can go over some of this in our next one-on-one if that's helpful.

templateForm.fields = templateForm.fields.filter(
(field) =>
!['assignedUserGroupIds', 'isUnrestricted'].includes(field.name),
);
}

templateForm.fields = templateForm.fields.map((field) => {
if (field.name === 'body') {
field.preparedContent = Object.keys(
Expand Down