pkp/pkp-lib#9892 upgrade to laravel 11 and PHP 8.2+ #4367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmecher
requested changes
Jul 30, 2024
| @@ -318,14 +324,14 @@ public function up(): void | |||
| $table->foreign('journal_id', 'subscription_types_journal_id')->references('journal_id')->on('journals')->onDelete('cascade'); | |||
| $table->index(['journal_id'], 'subscription_types_journal_id'); | |||
|
|
|||
| $table->float('cost', 8, 2); | |||
| $table->float('cost', 53); | |||
There was a problem hiding this comment.
The cost column should definitely be converted over to a decimal now that we're losing the precision and scale.
There was a problem hiding this comment.
Right . In that case, we should have a migration also, added .
| @@ -415,7 +421,7 @@ public function up(): void | |||
| $table->index(['user_id'], 'completed_payments_user_id'); | |||
|
|
|||
| $table->bigInteger('assoc_id')->nullable(); | |||
| $table->float('amount', 8, 2); | |||
| $table->float('amount', 53); | |||
There was a problem hiding this comment.
touhidurabir
force-pushed
the
i9892_main
branch
3 times, most recently
from
21a2f92 to
35c840c
Compare
touhidurabir
commented
Aug 7, 2024
touhidurabir
commented
Aug 7, 2024
asmecher
approved these changes
Aug 8, 2024
touhidurabir
force-pushed
the
i9892_main
branch
from
62c0439 to
ed304fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkp/pkp-lib#9892