Submission and metadata languages separated from UI and form languages #4040

jyhein · 2023-09-18T11:45:02Z

In Website Settings > Setup > Languages and in Administration > Hosted Journals > Settings Wizard > Journal Settings > Languages, separate Website Languages and Submission Languages settings. In the website languages are UI and Forms, and in the submission languages are submission and metadata.
Submission metadata can be edited even if metadata isn't checked in that language in the settings.

jyhein · 2023-09-20T18:14:34Z

Hey @asmecher,

I have PRs ready for review of the code...

PKP: pkp/pkp-lib#9309
OJS: #4040
OMP: pkp/omp#1461

asmecher · 2023-09-21T21:08:09Z

Thanks, @jyhein! @bozana, would you be able to review these?

bozana · 2023-10-04T08:27:21Z

I will take/am taking a look... It will take some time because I would also like to test it locally...

bozana · 2023-10-09T12:01:15Z

@jyhein, could we not user the journal primary locale for supportedDefaultSubmissionLocale?
Also, should maybe journal primary locale always be part of supportedAddedSubmissionLocales, supportedSubmissionLocales, and supportedSubmissionMetadataLocales?
Just asking to understand your decisions i.e. cases I maybe do not have on my mind, or technical difficulties I do not have on my mind or...

bozana · 2023-10-09T12:56:35Z

And maybe one more question right away, for me to understand it better when looking into the code:
I see, the submission (primary) locale is not necessarily in the list of supported metadata locales. How/when is this possible?
E.g.

$primaryLocale = $submission->getData('locale');
$allowedLocales = $context->getSupportedSubmissionMetadataLocales();
in_array($primaryLocale, $allowedLocales) || array_push($allowedLocales, $primaryLocale);

EDIT:
Oh, after our meeting I think I know the reason/case here: when journal has disabled a language that was used earlier, in which submissions already exist...

bozana

Thanks a lot, great work @jyhein!

bozana · 2023-10-09T12:22:32Z

classes/install/Upgrade.php

-        // supportedFormLocales, supportedLocales, supportedSubmissionLocales
-        $settingNames = "('supportedFormLocales', 'supportedLocales', 'supportedSubmissionLocales')";
+        // supportedFormLocales, supportedLocales, supportedAddedSubmissionLocales, supportedSubmissionLocales, supportedDefaultSubmissionLocale, supportedSubmissionMetadataLocales
+        $settingNames = "('supportedFormLocales', 'supportedLocales', 'supportedAddedSubmissionLocales', 'supportedSubmissionLocales', 'supportedDefaultSubmissionLocale', 'supportedSubmissionMetadataLocales')";


This upgrade function will only be executed for journals using version 3.1. Thus they will not have those settings, so I think this should not be considered here.

bozana · 2023-10-09T12:34:48Z

classes/publication/Repository.php

-        $primaryLocale = $submission->getLocale();
+        $primaryLocale = $submission->getData('locale');
+        $allowedLocales = $context->getSupportedSubmissionMetadataLocales();
+        in_array($primaryLocale, $allowedLocales) || array_push($allowedLocales, $primaryLocale);


It is more readable to use if statement:
if (!in_array($primaryLocale, $allowedLocales) ) { array_push($allowedLocales, $primaryLocale); }
Here and everywhere else in the code.

bozana · 2023-10-09T12:42:46Z

pages/workflow/WorkflowHandler.php

@@ -85,8 +85,9 @@ public function setupIndex($request)
            $submissionContext = Services::get('context')->get($submission->getContextId());
        }

-        $locales = $submissionContext->getSupportedSubmissionLocaleNames();
+        $locales = $submissionContext->getSupportedSubmissionMetadataLocaleNames() + [$submission->getData('locale') => (new \PKP\i18n\LocaleMetadata($submission->getData('locale')))->getDisplayName(null, false)];


Use:
use PKP\i18n\LocaleMetadata;
at the beginning of the file.

jyhein · 2023-10-27T08:16:54Z

Hey @bozana,
OJS is ready with changes.
PKP PR has comments to changes: pkp/pkp-lib#9309

bozana · 2023-11-07T13:52:08Z

classes/publication/Repository.php

-        $allowedLocales = $context->getSupportedSubmissionLocales();
-        $primaryLocale = $submission->getLocale();
+        $primaryLocale = $submission->getData('locale');
+        $allowedLocales = array_values(array_unique(array_merge($context->getSupportedSubmissionMetadataLocales(), $publication?->getLanguages() ?? [$primaryLocale])));


This is already considered in the parent::validate() or?

bozana · 2023-11-07T13:59:05Z

controllers/grid/articleGalleys/form/ArticleGalleyForm.php

@@ -62,17 +62,15 @@ public function __construct($request, $submission, $publication, $articleGalley
        $this->addCheck(new \PKP\form\validation\FormValidatorCSRF($this));

        // Ensure a locale is provided and valid
-        $journal = $request->getJournal();
+        $locales = $request->getJournal()->getSupportedSubmissionMetadataLocaleNames() + $publication->getLanguageNames();


The galley's locale, that has been removed, is not considered here, and maybe somewhere else too.
For example, this scenario:
EN, DE and FR are selected as submission locales.
Author submits an article in EN, with EN metadata.
Editor creates later a galley in DE, without entering DE metadata.
DE is removed as metadata locale (that means also as submission locale).
The galley in DE can not be edited correctly, its earlier locale is not considered.
I.e. galleys are connected with allowed submission locales -- a galley can be created in any enabled submission locale. It could happen -- probably rarely, but it could happen -- that there is only galley (and no metadata) in a different language than the submission primary language.

(The galleys locales tell us in which language a submission exists -- relevant to the removal of the DC language metadata field).

Should I add galleys/ publication formats (omp) locales to PKPPublication getLanguages-function then they would always be included ?

Hmmm... Now that I think about it...
I think galley locale can only be one of supportedSubmissionLocales, and not getSupportedSubmissionMetadataLocales. In order to consider the removed locales, the galley forms need to consider galleys locales too.
I like the idea of having everything at one place, in that function getLanguages(), also the galleys locales. The function however is then only relevant for metadata and not for galleys forms, I think... 🤔

bozana · 2024-03-08T14:47:30Z

controllers/grid/articleGalleys/form/ArticleGalleyForm.php

        $this->addCheck(
            new \PKP\form\validation\FormValidator(
                $this,
                'locale',
                'required',
                'editor.issues.galleyLocaleRequired'
            ),
-            function ($locale) use ($journal) {


I think this is not correct: addCheck only accepts one parameter, so I think this would need to be FormValidatorCustom, that will then have this function as parameter.
Could you please change it?

…m website language settings

jyhein force-pushed the f5000_7431 branch from 9cb6a20 to efb4abe Compare September 19, 2023 08:29

bozana mentioned this pull request Oct 9, 2023

Restrict what languages are available for new submissions pkp/pkp-lib#7431

Closed

jyhein mentioned this pull request Oct 18, 2023

Make submission language selection and metadata forms independent from website language settings pkp/pkp-lib#9425

Closed

bozana reviewed Oct 18, 2023

View reviewed changes

jyhein force-pushed the f5000_7431 branch from f75d693 to bcf1080 Compare October 27, 2023 05:40

jyhein force-pushed the f5000_7431 branch 2 times, most recently from 695c29c to 24ead38 Compare October 31, 2023 12:45

bozana reviewed Nov 8, 2023

View reviewed changes

jyhein force-pushed the f5000_7431 branch 2 times, most recently from 3988aaa to 2bd33bd Compare November 14, 2023 12:56

jyhein force-pushed the f5000_7431 branch 6 times, most recently from 162366e to 2994581 Compare February 7, 2024 10:35

jyhein force-pushed the f5000_7431 branch 4 times, most recently from 38dfc02 to 29aec7b Compare February 20, 2024 07:55

bozana reviewed Mar 8, 2024

View reviewed changes

jyhein force-pushed the f5000_7431 branch 3 times, most recently from 51ef640 to 10aecc6 Compare March 13, 2024 10:17

jyhein added 2 commits March 21, 2024 11:04

Make submission language selection and metadata forms independent fro…

913e101

…m website language settings

Submodule update ##jyhein/f5000_7431##

d8b4ce6

jyhein force-pushed the f5000_7431 branch from 10aecc6 to d8b4ce6 Compare March 21, 2024 09:06

bozana merged commit afcf029 into pkp:main Mar 21, 2024
3 checks passed

jyhein deleted the f5000_7431 branch April 25, 2024 11:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Submission and metadata languages separated from UI and form languages #4040

Submission and metadata languages separated from UI and form languages #4040

jyhein commented Sep 18, 2023

jyhein commented Sep 20, 2023

asmecher commented Sep 21, 2023

bozana commented Oct 4, 2023

bozana commented Oct 9, 2023 •

edited

Loading

bozana commented Oct 9, 2023 •

edited

Loading

bozana left a comment

bozana Oct 9, 2023

bozana Oct 9, 2023

bozana Oct 9, 2023

jyhein commented Oct 27, 2023

bozana Nov 7, 2023

bozana Nov 7, 2023

jyhein Nov 8, 2023

bozana Nov 8, 2023 •

edited

Loading

bozana Mar 8, 2024

Submission and metadata languages separated from UI and form languages #4040

Submission and metadata languages separated from UI and form languages #4040

Conversation

jyhein commented Sep 18, 2023

jyhein commented Sep 20, 2023

asmecher commented Sep 21, 2023

bozana commented Oct 4, 2023

bozana commented Oct 9, 2023 • edited Loading

bozana commented Oct 9, 2023 • edited Loading

bozana left a comment

Choose a reason for hiding this comment

bozana Oct 9, 2023

Choose a reason for hiding this comment

bozana Oct 9, 2023

Choose a reason for hiding this comment

bozana Oct 9, 2023

Choose a reason for hiding this comment

jyhein commented Oct 27, 2023

bozana Nov 7, 2023

Choose a reason for hiding this comment

bozana Nov 7, 2023

Choose a reason for hiding this comment

jyhein Nov 8, 2023

Choose a reason for hiding this comment

bozana Nov 8, 2023 • edited Loading

Choose a reason for hiding this comment

bozana Mar 8, 2024

Choose a reason for hiding this comment

bozana commented Oct 9, 2023 •

edited

Loading

bozana commented Oct 9, 2023 •

edited

Loading

bozana Nov 8, 2023 •

edited

Loading