clearer errors

"Not found" should only be for http path/method not found (404)
if it's about specific resources, we should be explicit for clarity

pkg/api/dashboard_snapshot.go

@@ -59,7 +59,7 @@ func GetDashboardSnapshot(c *middleware.Context) {
 
 	// expired snapshots should also be removed from db
 	if snapshot.Expires.Before(time.Now()) {
-		c.JsonApiErr(404, "Snapshot not found", err)
+		c.JsonApiErr(404, "Dashboard snapshot not found", err)
 		return
 	}
 

pkg/models/dashboards.go

@@ -11,6 +11,7 @@ import (
 // Typed errors
 var (
 	ErrDashboardNotFound           = errors.New("Dashboard not found")
+	ErrDashboardSnapshotNotFound   = errors.New("Dashboard snapshot not found")
 	ErrDashboardWithSameNameExists = errors.New("A dashboard with the same name already exists")
 	ErrDashboardVersionMismatch    = errors.New("The dashboard has been changed by someone else")
 )

pkg/models/models.go

@@ -1,13 +1,9 @@
 package models
 
-import "errors"
-
 type OAuthType int
 
 const (
 	GITHUB OAuthType = iota + 1
 	GOOGLE
 	TWITTER
 )
-
-var ErrNotFound = errors.New("Not found")

pkg/services/sqlstore/dashboard_snapshot.go

@@ -57,7 +57,7 @@ func GetDashboardSnapshot(query *m.GetDashboardSnapshotQuery) error {
 	if err != nil {
 		return err
 	} else if has == false {
-		return m.ErrNotFound
+		return m.ErrDashboardSnapshotNotFound
 	}
 
 	query.Result = &snapshot