#62 fix extension renderers and add some defensive code for content r…

…endering issues
pixl8 · Jul 12, 2022 · b4a2834 · b4a2834
1 parent 466963f
commit b4a2834
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/handlers/renderers/content/DataApiPageLink.cfc b/handlers/renderers/content/DataApiPageLink.cfc
@@ -6,5 +6,7 @@ component {
 		if ( pageId.len() ) {
 			return event.buildLink( page=pageId );
 		}
+
+		return "";
 	}
 }
diff --git a/handlers/renderers/content/DataApiPageLinkArray.cfc b/handlers/renderers/content/DataApiPageLinkArray.cfc
@@ -1,6 +1,6 @@
 component {
 
-	private string function default( event, rc, prc, args={} ){
+	private array function default( event, rc, prc, args={} ){
 		var pages = ListToArray( args.data ?: "" );
 
 		for( var i=1; i<=pages.len(); i++ ) {

diff --git a/services/DataApiService.cfc b/services/DataApiService.cfc
@@ -325,13 +325,19 @@ component {
 		}
 
 		if ( $getContentRendererService().rendererExists( renderer, "dataapi" ) ) {
-			var renderedContent = $renderContent( renderer, arguments.value, "dataapi", arguments.fieldSettings );
-			if ( Len( renderedContent ?: "" ) ) {
-				return renderedContent;
+			try {
+				var renderedContent = $renderContent( renderer, arguments.value, "dataapi", arguments.fieldSettings );
+				if ( Len( renderedContent ?: "" ) ) {
+					return renderedContent;
+				}
+			} catch( any e ) {
+				$raiseError( e );
 			}
-
 		}
 
+		if ( Len( arguments.value ?: "" ) ) {
+			return arguments.value;
+		}
 		return $isFeatureEnabled( "dataApiUseNullForStrings" )  ? NullValue() : "";
 	}