Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESIDECMS-2946 object attribute batch editable default #1538

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from
Open

PRESIDECMS-2946 object attribute batch editable default #1538

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2b42da
[twgit] Init feature 'feature-PRESIDECMS-2946_object-attribute-batchE…
sebduggan Oct 8, 2024
aa0d402
PRESIDECMS-2946 Add batchEditableDefault attribute to objects
sebduggan Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions system/services/admin/DataManagerService.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,12 +182,13 @@ component {

var fields = [];
var propertyNames = _getPresideObjectService().getObjectAttribute( objectName=objectName, attributeName="propertyNames" );
var batchEditableDefault = _getPresideObjectService().getObjectAttribute( objectName=objectName, attributeName="batchEditableDefault", defaultValue=true );
var props = _getPresideObjectService().getObjectProperties( objectName );
var dao = _getPresideObjectService().getObject( objectName );
var forbiddenFields = [ dao.getIdField(), dao.getLabelField(), dao.getDateCreatedField(), dao.getDateModifiedField(), dao.getFlagField() ];
var isFieldBatchEditable = function( propertyName, attributes ) {
if ( forbiddenFields.findNoCase( propertyName ) ) {
return false
return false;
}
if ( attributes.relationship == "one-to-many" ) {
return false;
Expand All @@ -201,11 +202,11 @@ component {
if ( propertyName.reFind( "^_" ) ) {
return false;
}
if ( IsBoolean( attributes.batcheditable ?: "" ) && !attributes.batcheditable ) {
return false;
if ( IsBoolean( attributes.batcheditable ?: "" ) ) {
return attributes.batcheditable;
}

return true;
return batchEditableDefault;
}

for( var propertyName in propertyNames ) {
Expand Down
Loading