PRESIDECMS-2745 add various request level caching to rules engine #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Calculation of any given context's payload * Evaluation of an individual expression * Evaluation of an entire condition * Various other calculations The idea here is that the result of condition and expression evaluation will not change within the scope of a request and neither will a payload for a given context. In complicated pages with a lot of conditions to run, we can save a lot of resource by caching results. n.b. While here, also reduce use of member functions.
* Calculation of any given context's payload * Evaluation of an individual expression * Evaluation of an entire condition * Various other calculations The idea here is that the result of condition and expression evaluation will not change within the scope of a request and neither will a payload for a given context. In complicated pages with a lot of conditions to run, we can save a lot of resource by caching results. n.b. While here, also reduce use of member functions.
…s with the unnatural nature of the test
…aching' of github.com:pixl8/Preside-CMS into feature-PRESIDECMS-2745_rules-engine-condition-result-caching
…l sends where the context can change in the life of the 'request'
…ached query This should prevent any compatibility issues where other logic performs this same query and uses the expressions field
This is not necessary as the cache key contains the context payload + expression config so will be fine when context changing in a bg thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRESIDECMS-2745 add various request level caching to rules engine.
The idea here is that the result of condition and expression evaluation
will not change within the scope of a request and neither will a payload
for a given context. In complicated pages with a lot of conditions to run,
we can save a lot of resource by caching results.
n.b. While here, also reduce use of member functions.