Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature presidecms 2725 failed to start app on mssql #1374

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from
Open

Feature presidecms 2725 failed to start app on mssql #1374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc78588
[twgit] Init feature 'feature-PRESIDECMS-2725_failed_to_start_app_on_…
mookesh Oct 11, 2023
9e0d229
PRESIDECMS-2725 fix DB error when starting up preside on MSSQL
mookesh Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/preside-objects/email/email_template.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ component extends="preside.system.base.SystemPresideObject" displayname="Email t

property name="attachments" relationship="many-to-many" relatedto="asset" relatedVia="email_template_attachment";

property name="variant_of" relationship="many-to-one" relatedto="email_template" required=false;
property name="variant_of" relationship="many-to-one" relatedto="email_template" required=false ondelete="set-null-if-no-cycle-check" onupdate="cascade-if-no-cycle-check";
property name="is_variant" type="boolean" formula="case when ${prefix}variant_of is null then 0 else 1 end";

property name="email_blueprint" relationship="many-to-one" relatedTo="email_blueprint";
Expand Down
2 changes: 1 addition & 1 deletion system/preside-objects/formbuilder/formbuilder_form.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ component displayname="Form builder: form" extends="preside.system.base.SystemPr
property name="notification_enabled" type="boolean" dbtype="boolean" required=false default=false;

property name="require_login" type="boolean" dbtype="boolean" required=false default=false;
property name="access_condition" relationship="many-to-one" relatedto="rules_engine_condition" required=false control="conditionPicker" ruleContext="webrequest";
property name="access_condition" relationship="many-to-one" relatedto="rules_engine_condition" required=false control="conditionPicker" ruleContext="webrequest" ondelete="set-null-if-no-cycle-check" onupdate="cascade-if-no-cycle-check";
property name="login_required_content" type="string" dbtype="text" required=false;
property name="access_denied_content" type="string" dbtype="text" required=false;

Expand Down
2 changes: 1 addition & 1 deletion system/preside-objects/rulesEngine/rules_engine_condition.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ component extends="preside.system.base.SystemPresideObject" displayName="Rules e
property name="is_segmentation_filter" type="boolean" dbtype="boolean" default=false batchEditable=false;
property name="segmentation_frequency_measure" type="numeric" dbtype="int" batchEditable=false minValue=1;
property name="segmentation_frequency_unit" type="string" dbtype="varchar" maxlength=10 batchEditable=false enum="segmentationFilterTimeUnit";
property name="parent_segmentation_filter" relationship="many-to-one" relatedto="rules_engine_condition" batchEditable=false uniqueindexes="filterobjectname|3" ondelete="cascade-if-no-cycle-check";
property name="parent_segmentation_filter" relationship="many-to-one" relatedto="rules_engine_condition" batchEditable=false uniqueindexes="filterobjectname|3" ondelete="cascade-if-no-cycle-check" onupdate="cascade-if-no-cycle-check";
property name="segmentation_last_calculation" type="date" dbtype="datetime" batcheditable=false ignoreChangesForVersioning=true renderer="lastSegmentationRuleCalculation";
property name="segmentation_next_calculation" type="date" dbtype="datetime" batcheditable=false ignoreChangesForVersioning=true;
property name="segmentation_last_count" type="numeric" dbtype="int" required=false default=0 batcheditable=false ignoreChangesForVersioning=true;
Expand Down
1 change: 1 addition & 0 deletions system/services/database/adapters/MsSqlAdapter.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ component extends="BaseAdapter" {
columnDef &= "datetime";
break;
case "longtext":
case "mediumtext":
case "text":
arguments.maxLength = 0;
columnDef &= _getUseVarcharMaxForText() ? "varchar(max)" : "text";
Expand Down