Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRESIDECMS-2713 use faster Lucee 6 dbinfo when available #1364

Merged
merged 3 commits into from
Oct 2, 2023
Merged

PRESIDECMS-2713 use faster Lucee 6 dbinfo when available #1364

merged 3 commits into from
Oct 2, 2023

Conversation

zspitzer
Copy link
Contributor

DominicWatson
DominicWatson requested changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@DominicWatson DominicWatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome looks great. Just one comment re changing the test suite Lucee version (we shouldn't be).

tests/server.json Outdated Show resolved Hide resolved
@zspitzer zspitzer marked this pull request as draft September 20, 2023 16:57
@zspitzer zspitzer force-pushed the modern-dbinfo branch 3 times, most recently from b23cdfc to 02b5875 Compare September 21, 2023 07:21
@zspitzer
Copy link
Contributor Author

Been testing, this reduces the db sync time by about roughly 50% on my fast laptop, 12s to 7s

@zspitzer zspitzer marked this pull request as ready for review September 25, 2023 09:05
@DominicWatson
Copy link
Contributor

Great, thanks for the tidy up also. Will get this merged and in use internally for QA against existing Lucee.

@DominicWatson DominicWatson merged commit 71b7cd6 into pixl8:stable Oct 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominicWatson DominicWatson DominicWatson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zspitzer @DominicWatson