PRESIDECMS-2715 code comment on some odd looking code

pixl8 · Sep 21, 2023 · 613c2ed · 613c2ed
1 parent a8cde8a
commit 613c2ed
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/system/services/taskmanager/AdHocTaskManagerService.cfc b/system/services/taskmanager/AdHocTaskManagerService.cfc
@@ -447,7 +447,7 @@ component displayName="Ad-hoc Task Manager Service" {
 		return $getPresideObject( "taskmanager_adhoc_task_log_line" ).selectData(
 			  selectFields = [ "ts", "severity", "line" ]
 			, orderby      = "id"
-			, maxRows      = 1000000
+			, maxRows      = arguments.fetchAfterLines ? 1000000 : 0 // impossibly high number. Forcing startRow to work without really wanting a max rows
 			, startRow     = arguments.fetchAfterLines + 1
 			, filter       = { task=arguments.taskId }
 		);

diff --git a/system/services/taskmanager/TaskManagerService.cfc b/system/services/taskmanager/TaskManagerService.cfc
@@ -664,7 +664,7 @@ component displayName="Task Manager Service" {
 		return $getPresideObject( "taskmanager_task_history_log_line" ).selectData(
 			  selectFields = [ "ts", "severity", "line" ]
 			, orderby      = "id"
-			, maxRows      = 1000000
+			, maxRows      = arguments.fetchAfterLines ? 1000000 : 0 // impossibly high number. Forcing startRow to work without really wanting a max rows
 			, startRow     = arguments.fetchAfterLines + 1
 			, filter       = { history=arguments.historyId }
 		);