remove self from redis_object from _add_vector in RedisStorage #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like CI is broken? |
sarthakTUM
requested review from
pixelogik
and removed request for
pixelogik
|
LGTM |
sarthakTUM
changed the title
|
Any updates on this PR? |
|
@amorgun do you have to rights to merge? |
|
No, I cannot merge requests. We have to wait for @pixelogik. |
|
@amorgun @sarthakTUM Sorry for the long silence. Last year was crazy because of Covid, work and family. I do not have much time for this project anymore. Are you interested in joining the project so that you can also accept pull requests? |
|
no problem, I hope you are doing fine @pixelogik. Sure, I am happy to join this project. |
|
@pixelogik Yes, I would like to join the project. |
|
@amorgun @sarthakTUM I invited you both as contributors. Looking forward to working together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #88