Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis object not used in the _add_vector function #88

Open
sarthakTUM opened this issue Feb 16, 2020 · 4 comments
Open

redis object not used in the _add_vector function #88

sarthakTUM opened this issue Feb 16, 2020 · 4 comments

Comments

@sarthakTUM
Copy link
Collaborator

sarthakTUM commented Feb 16, 2020 •
edited
Loading

Minor issue.

The redis_object in the _add_vector function of the storage_redis.py is not being used since the redis_object is already associated with self, and it should not be passed as an argument to the function.
@sarthakTUM sarthakTUM mentioned this issue Feb 16, 2020
Open
@amorgun
Copy link
Collaborator

amorgun commented Feb 16, 2020

Thanks for notising this. redis_object should be used here instead of self.redis_object. This argument is necessary for store_many_vectors method.

@sarthakTUM
Copy link
Collaborator Author

I'll revise the PR

@sarthakTUM
Copy link
Collaborator Author

Thanks for notising this. redis_object should be used here instead of self.redis_object. This argument is necessary for store_many_vectors method.

Done

@sarthakTUM
Copy link
Collaborator Author

@amorgun Could you please check the PR? - I am not able to add you as a reviewer there. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amorgun @sarthakTUM