Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FAQ #4
Add FAQ #4
Changes from all commits
c0978bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we're going to do this imminently, it feels like we should just mention it directly here. How's something like this?
This is all confusing enough that it may be better to just say nothing -- after all, if we can't do something because we don't have an OpenAI key present, should we just warn the user at stdout at that time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this feature needs to be opt-in from the CLI (for codemodder too) and we should be explicit about when it occurs. I don't think we can assume just because an
OPENAI_API_KEY
is defined that the user is okay with us spending their money and/or sending their code implicitly. Also I don't think we want to be specific about a particular vendor here since we may at some point send data to other vendors and/or our own services.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you take it as implied consent if we only honor a
PIXEE_OPENAI_API_KEY
?I've seen lots of sites now that ask me to acknowledge OpenAI as a subprocessor and consent to sending data to them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that feels more like a proper opt-in to me. Is it okay to keep this text relatively general for now and then update to mention OpenAI later once those features are available?