add threading codemod docs #88
Conversation
docs/codemods/python/pixee_python_safe-bad-lock-with-statement.md
Outdated
Show resolved
Hide resolved
|
|
||
| ### Why is this codemod marked as Merge After Cursory Review? | ||
|
|
||
| This codemod creates a new variable named `lock` which could clash with another variable of the same name in the module. |
There was a problem hiding this comment.
is this too honest?
There was a problem hiding this comment.
Haha I think it's honest enough but honestly I'm thinking maybe we should just address this in the codemod before we go public with this one. I've got a ticket for it in the backlog but not entirely sure how much effort is involved.
There was a problem hiding this comment.
Sounds reasonable to address it there as well, so leave this as is?
There was a problem hiding this comment.
@clavedeluna what I mean is we should fix this behavior in the codemod by automatically deconflicting variable names.
There was a problem hiding this comment.
ah, turns out calling deep_equals predates having file_context.codemod_changes so I think as long as you replace the deep_equals call with checking if there are any changes (and we assume that we always record the change), then we should be good
|
clavedeluna
force-pushed
the
py-threading
branch
from
e256298 to
8d692e6
Compare
clavedeluna
force-pushed
the
py-threading
branch
from
8d692e6 to
df65886
Compare
|
this is now ready for final review along with pixee/codemodder-python#78 |
No description provided.