Minor updates to the docs and script #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #98 +/- ##
=======================================
Coverage ? 95.22%
=======================================
Files ? 51
Lines ? 2285
Branches ? 0
=======================================
Hits ? 2176
Misses ? 109
Partials ? 0
|
clavedeluna
approved these changes
Oct 25, 2023
drdavella
force-pushed
the
small-docs-fixes
branch
from
7a3e610 to
734d66d
Compare
drdavella
force-pushed
the
small-docs-fixes
branch
from
734d66d to
586422a
Compare
andrecsilva
approved these changes
Oct 25, 2023
| @@ -1,6 +1,6 @@ | |||
| This codemod refactors SQL statements to be parameterized, rather than built by hand. | |||
|
|
|||
| Without parameterization, developers must remember to escape string inputs using the rules for that column type and database. This usually results in bugs -- and sometimes vulnerability. Although it's not clear if this code is exploitable today, this change will make the code more robust in case the conditions which prevent exploitation today ever go away. | |||
| Without parameterization, developers must remember to escape string inputs using the rules for that column type and database. This usually results in bugs -- and sometimes vulnerabilities. Although we can't tell for sure if your code is actually exploitable, this change will make the code more robust in case the conditions which prevent exploitation today ever go away. | |||
There was a problem hiding this comment.
You might want to also update the Java version of SQL parameterization. This was lifted straight from there.
| @@ -34,7 +34,7 @@ | |||
|
|
|||
|
|
|||
| class SQLQueryParameterization(BaseCodemod, UtilsMixin, Codemod): | |||
| SUMMARY = "Parameterize SQL queries." | |||
| SUMMARY = "Parameterize SQL Queries" | |||
There was a problem hiding this comment.
I see no reason for the capitalization here.
There was a problem hiding this comment.
This becomes the title of the PR and the docs, which are capitalized for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.