Avoid duplicate findings from multiple sarif files #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunningdan
approved these changes
Nov 21, 2024
clavedeluna
approved these changes
Nov 22, 2024
| @@ -11,6 +11,7 @@ readme = "README.md" | |||
| license = {file = "LICENSE"} | |||
| description = "A pluggable framework for building codemods in Python" | |||
| dependencies = [ | |||
| "boltons~=21.0.0", | |||
There was a problem hiding this comment.
TIL! Will become my new favorite utility, I"m sure
drdavella
force-pushed
the
avoid-duplicate-findings
branch
from
e0115e8 to
a77025c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Avoid duplicating preexisting findings when processing multiple (potentially duplicate) SARIF files for a given tool
Description
IndexedSetto enforce uniqueness when combiningResultSetsIndexedSetpreserves ordering 👍Resulttype needs to be hashable. This required the following changesfrozendatatypesfrozenpydantic classeslist(not hashable) in these types withtuple(hashable)