Initial Version of SQL Parameterizer Codemod

[andrecsilva]

Overview

Adds a codemod that parameterizes SQL queries.

[drdavella]

This is some really impressive work overall. I'm relying heavily on the test cases to help me understand the feature. Most of my comments are minor in themselves but I think they all add up to a requested change.

[drdavella]

We have some similar logic in use-walrus-if:

codemodder-python/src/core_codemods/use_walrus_if.py

Lines 93 to 95 in 7112886

	if parent := self.get_metadata(ParentNodeProvider, node):
	if gparent := self.get_metadata(ParentNodeProvider, parent):
	if (idx := gparent.children.index(parent)) >= 0:

It might be useful to generalize this into a separate utility function.

[andrecsilva]

We could go the way of NameResolutionMixin and make something like ParentProviderMixin, but this feels like a small enough operation that it does not warrant a whole class for it. Besides I can't think of another operation that would go into that class and be used in other codemods for now.

[drdavella]

I was thinking something more like a simple function/method that returned a grandparent node but it's not that important.

[drdavella]

I think this ends up being cleaner if we use codemodder.api.BaseCodemod as the base here instead. It requires a few tweaks to the metadata fields.

[andrecsilva]

I want it to inherit from libcst's Codemod and not BaseTransformer -> VisitorBasedCodemodCommand.

[clavedeluna]

Yeah and as long as we inherit from libcst's Codemod we can't use our current API. We'll have to create api base classes for this later on

[codecov]

Codecov Report

Merging #90 (efdbd14) into main (6187027) will decrease coverage by 0.55%.
The diff coverage is 91.24%.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   95.72%   95.18%   -0.55%     
==========================================
  Files          49       51       +2     
  Lines        2012     2284     +272     
==========================================
+ Hits         1926     2174     +248     
- Misses         86      110      +24     

Files	Coverage Δ
src/core_codemods/__init__.py	100.00% <100.00%> (ø)
...ansformations/remove_empty_string_concatenation.py	95.65% <95.65%> (ø)
src/codemodder/codemods/utils.py	89.79% <86.66%> (-5.45%)	⬇️
src/core_codemods/sql_parameterization.py	91.36% <91.36%> (ø)

[andrecsilva]

The 100% coverage here is not happening unless I remove the formatted string placeholders and some sanity checks (e.g. the exception in _find_gparent()).

[drdavella]

Looks good except for two minor comments that need to be addressed.

[drdavella]

I don't think this was intended to be committed. Can you add a pattern to .gitignore so we avoid this in the future?

[andrecsilva]

We need this to run the integration test without issues.

[drdavella]

In general I'd like to avoid committing binary artifacts like this to the source tree. I don't want to hold this PR up any longer but eventually we should create this database as part of the test setup and then remove it at teardown.

[andrecsilva]

I just learned that you can create a memory-only database with the ":memory:" argument in sqlite3. I'll adjust the integration test and remove the extra file.