-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ChangeSet to CodeTF when adding dependency to requirements.txt #86
Conversation
Codecov Report
@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 95.94% 95.70% -0.24%
==========================================
Files 48 48
Lines 1900 1957 +57
==========================================
+ Hits 1823 1873 +50
- Misses 77 84 +7
|
d03c055
to
0dbf622
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, still not sure about integrating the DM here to codemodder, but at least it will make things easier. Maybe we can separate them later when the project is a bit more mature.
@andrecsilva I agree that we can/should revisit this eventually. There are two major considerations right now:
|
0dbf622
to
2e44dc0
Compare
Overview
Dependency updates now result in new
ChangeSet
entry in CodeTFDescription
ChangeSet
entry in CodeTFChangeSet
entryDependencyManager
since it needs to be able to generate a diff and provide some contextual informationDependencyManager
if it's in the same git source tree.use-defusedxml
now adds a dependency but there is still additional work before it can be enabled