Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report failed parsing #75

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Report failed parsing #75

merged 3 commits into from
Oct 17, 2023

Conversation

clavedeluna
Copy link
Contributor

@clavedeluna clavedeluna commented Oct 16, 2023

Overview

Codetf report should include list of fails that filed to be cst parsed or codemod-transformed

Description

  • previously we have been skipping reporting for a codemod if it had no results, however this doesn't really align with having a list of failed files. All files could fail so there would be no results. We should report anyway
  • @drdavella I do need confirmation that this is ok with pixeebot - that a codemod without anything in changeset will still be in the report.
  • we now also report fails that were either not correctly cst parsed (already handled) and not able to be transformed by a codemod (new)
  • added corresponding test cases to demonstrate.

@clavedeluna
Copy link
Contributor Author

the pygoat failure may now be expected, need to investigate

andrecsilva
andrecsilva previously approved these changes Oct 17, 2023
@andrecsilva andrecsilva dismissed their stale review October 17, 2023 11:23

Changes look good, but didn't notice the failures

@clavedeluna clavedeluna force-pushed the failed-files branch 2 times, most recently from 732c6a1 to 176ba7f Compare October 17, 2023 12:22
Copy link
Member

@drdavella drdavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great but I want to hold off on the one behavior change you introduced for now.

src/codemodder/codemodder.py Outdated Show resolved Hide resolved
@clavedeluna clavedeluna changed the title Report failed parsing or transformation Report failed parsing Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #75 (914be8b) into main (6290be0) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   96.22%   96.21%   -0.01%     
==========================================
  Files          46       46              
  Lines        1826     1824       -2     
==========================================
- Hits         1757     1755       -2     
  Misses         69       69              
Files Coverage Δ
src/codemodder/context.py 100.00% <ø> (ø)

@clavedeluna clavedeluna merged commit 21ae8b2 into main Oct 17, 2023
11 checks passed
@clavedeluna clavedeluna deleted the failed-files branch October 17, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants