-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove global state #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdavella
force-pushed
the
fix-global-state
branch
from
September 14, 2023 17:56
a2168d7
to
617c75a
Compare
drdavella
commented
Sep 14, 2023
|
||
[tool.pytest.ini_options] | ||
# Ignore integration tests and ci tests by default | ||
testpaths = ["tests"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could include integration tests here if we want but mainly I want to avoid running the webgoat tests by accident.
andrecsilva
approved these changes
Sep 15, 2023
drdavella
force-pushed
the
fix-global-state
branch
from
September 15, 2023 17:14
617c75a
to
71cf85b
Compare
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 95.67% 95.69% +0.01%
==========================================
Files 38 37 -1
Lines 1340 1346 +6
==========================================
+ Hits 1282 1288 +6
Misses 58 58
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove the use of global state; other miscellaneous code cleanup
Description
DependencyManager
also effectively stored global state since it's implemented in terms of aSingleton
CodemodExecutionContext
which is used to store centralized state