Updates to fix-mutable-params codemod #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 96.33% 96.35% +0.01%
==========================================
Files 66 66
Lines 2732 2743 +11
==========================================
+ Hits 2632 2643 +11
Misses 100 100
|
drdavella
commented
Nov 17, 2023
| def _is_abstractmethod(self, node: cst.FunctionDef) -> bool: | ||
| for decorator in node.decorators: | ||
| match decorator.decorator: | ||
| case cst.Name("abstractmethod"): |
There was a problem hiding this comment.
Could possibly be more accurate and guarantee this is imported from abc, but it's probably pretty reliable as-is.
andrecsilva
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates to
fix-mutable-paramsDescription
Optionalabstractmethods