Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle requirements.txt files without trailing newlines #140

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

drdavella
Copy link
Member

@drdavella drdavella commented Nov 17, 2023

Overview

Correctly generate diffs when adding dependencies to requirements.txt files without trailing newlines

Description

  • This was fixed for libcst codemods in general but requirements.txt is a special case

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #140 (a369f68) into main (d0414dd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files          65       66    +1     
  Lines        2727     2732    +5     
=======================================
+ Hits         2627     2632    +5     
  Misses        100      100           
Files Coverage Δ
src/codemodder/codemodder.py 97.01% <100.00%> (-0.05%) ⬇️
src/codemodder/dependency_manager.py 92.98% <100.00%> (+0.25%) ⬆️
src/codemodder/diff.py 100.00% <100.00%> (ø)

@drdavella drdavella marked this pull request as ready for review November 17, 2023 18:41
@drdavella drdavella added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit cded591 Nov 17, 2023
13 checks passed
@drdavella drdavella deleted the fix-diff-requirements branch November 17, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants