Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect custom loaders in harden-pyyaml #132

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Respect custom loaders in harden-pyyaml #132

merged 2 commits into from
Nov 15, 2023

Conversation

drdavella
Copy link
Member

@drdavella drdavella commented Nov 14, 2023

Overview

harden-pyyaml should not replace custom loaders

Description

  • In order to avoid breaking custom code, we need to be careful to respect the presence of custom YAML loaders
  • While we can't detect whether such loaders are actually safe, making this change would likely result in broken code

@drdavella drdavella changed the title Respect custom codemods in harden-pyyaml Respect custom loaders in harden-pyyaml Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #132 (13063c8) into main (954a20e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          64       64           
  Lines        2612     2612           
=======================================
  Hits         2503     2503           
  Misses        109      109           
Files Coverage Δ
src/core_codemods/harden_pyyaml.py 100.00% <ø> (ø)

@drdavella drdavella marked this pull request as ready for review November 14, 2023 20:50
@drdavella drdavella added this pull request to the merge queue Nov 15, 2023
@drdavella drdavella removed this pull request from the merge queue due to the queue being cleared Nov 15, 2023
@drdavella drdavella added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit cce0b02 Nov 15, 2023
12 checks passed
@drdavella drdavella deleted the fix-yaml-codemods branch November 15, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants