convert django debug codemod to use codemod api #123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Convert one codemod to use codemod API instead of basecodemod directly. I recognized the opportunity to make this codemod much smaller. Instead of having one codemod class and one transformer, I made it all into one small class. Since this codemod only cares about settings.py files, we can use the fact that
visit_Module
checks if we should even visit the module. If so, this codemod will run atleave_Assign
If we like this change, I think I can make the same for django cookie secure off codemod