Capture and log semgrep process errors

pixee · Nov 13, 2023 · d12990b · d12990b
1 parent 638dc87
commit d12990b
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/codemodder/semgrep.py b/src/codemodder/semgrep.py
@@ -37,12 +37,16 @@ def run(
         )
         command.extend(map(str, files_to_analyze or [execution_context.directory]))
         logger.debug("semgrep command: `%s`", " ".join(command))
-        subprocess.run(
+        call = subprocess.run(
             command,
             shell=False,
-            check=True,
+            check=False,
             stdout=None if execution_context.verbose else subprocess.PIPE,
             stderr=None if execution_context.verbose else subprocess.PIPE,
         )
+        if call.returncode != 0:
+            if not execution_context.verbose:
+                logger.error("captured semgrep stderr: %s", call.stderr)
+            raise subprocess.CalledProcessError(call.returncode, command)
         results = SarifResultSet.from_sarif(temp_sarif_file.name)
         return results